rems cache removed when downloading historic

[steffilazerte]

Sorry for the separate issues (I think they're different problems).

In #61 I mentioned that sometimes my rems cache gets removed. I'm not sure if this is meant to happen, but it looks like if the rems cache directory exists, the entire folder is removed when updating historic data... but presumably that isn't meant to happen?

This also removed recent data, and means that my historical data update fails because there's no rems cache folder anymore

rems/R/ems_sqlite.R

Lines 67 to 70 in 9d228b7

	if (db_exists) {
	unlink(dirname(db_path), recursive = TRUE)
	write_db_path()
	}

Presumably, if the rems cache folder isn't deleted, then my other issue #61 is much less relevant...

Is there something I'm missing?

[ateucher]

I think you're on to something! I'll have a look

[ateucher]

@steffilazerte would you mind testing? You can install from the fix-historic-removal branch.

[steffilazerte]

Will do, but probably tomorrow!

[steffilazerte]

Tested updating existing recent and historical, as well as downloading fresh recent and historical and the cache updated with no problems!. Thanks!