Skip to content

Update GitHub workflows #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged

Update GitHub workflows #173

merged 1 commit into from
Apr 5, 2025

Conversation

braydencstratusadv
Copy link
Collaborator

@braydencstratusadv braydencstratusadv commented Apr 4, 2025

  • I have re-made the branch in bcgov
  • This new PR should address the comments in the previous PR, and the workflow is now cleaned up
  • I'm thinking the build_target_branch will continue to fail, until github_settings.py is in main

Added:

  • Copied .github/github_settings.py to bcap/settings.py
  • Missing dependencies (oracledb, html2text) to pyproject.toml

Changes:

  • Switched from pip to uv in build-and-test-branch/action.yml for faster setup and Python package installation

Issues:

  • There are outstanding migrations in arches, so I have limited makemigrations in build-and-test-branch/action.yml to just the bcap project for now
  • I ran into "Arches requirement is invalid, missing, or from a URL" while running the pipeline, so I have silenced it in .github/github_settings.py

Copy link
Collaborator

@bferguso bferguso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -27,6 +27,7 @@
"arches-dev-dependencies": "archesproject/arches-dev-dependencies#stable/7.6.4"
},
"dependencies": {
"ajv": "^8.17.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've ben using zod in another project, but I'd be interested in comparing ajv-ts w/ zod to see how they compare.

@@ -0,0 +1,49 @@
# Generated by Django 4.2.20 on 2025-04-04 16:01

from django.db import migrations, models
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually remove this view from BCAP as it's not relevant here, but I'll submit this as a separate PR and assign to you as this is looking great otherwise.

@bferguso bferguso merged commit 92b88a1 into main Apr 5, 2025
14 of 15 checks passed
@bferguso bferguso deleted the update-github-workflow branch April 5, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants