18490 Add displayLedger flag

[kzdev420]

Issue #: /bcgov/entity#18490

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

[severinbeauvais]

Do not merge until we decide whether to proceed with this or not (per Thor / Mihai). Yes, we need this.

[severinbeauvais]

Kevin, there are no changed files atm.

[kzdev420]

Kevin, there are no changed files atm.

Yeah, I think we don't need to changes the legal-API for this

[codecov]

Codecov Report

Attention: 223 lines in your changes are missing coverage. Please review.

Comparison is base (79511cd) 77.37% compared to head (e65de48) 76.66%.
Report is 63 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2351      +/-   ##
==========================================
- Coverage   77.37%   76.66%   -0.72%     
==========================================
  Files         202      168      -34     
  Lines       11602    10516    -1086     
  Branches     1961     1785     -176     
==========================================
- Hits         8977     8062     -915     
+ Misses       2043     1969      -74     
+ Partials      582      485      -97     

Flag	Coverage Δ
entityfiler	?
legalapi	76.66% <58.70%> (-0.18%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
legal-api/src/legal_api/config.py	95.16% <100.00%> (+0.28%)	⬆️
legal-api/src/legal_api/core/meta/filing.py	89.78% <ø> (-1.34%)	⬇️
legal-api/src/legal_api/models/__init__.py	100.00% <100.00%> (ø)
legal-api/src/legal_api/models/dc_definition.py	90.69% <100.00%> (ø)
...l-api/src/legal_api/models/dc_revocation_reason.py	100.00% <100.00%> (ø)
legal-api/src/legal_api/models/filing.py	92.41% <ø> (ø)
...s/v2/business/business_filings/business_filings.py	65.60% <100.00%> (+6.32%)	⬆️
...gal_api/services/filings/validations/alteration.py	83.01% <100.00%> (ø)
...gal_api/services/filings/validations/validation.py	77.95% <100.00%> (+1.09%)	⬆️
...al-api/src/legal_api/utils/legislation_datetime.py	84.12% <100.00%> (+0.79%)	⬆️
... and 13 more

... and 49 files with indirect coverage changes

[severinbeauvais]

Do you have a test that the value is True for all filings except Admin Freeze?

[kzdev420]

Do you have a test that the value is True for all filings except Admin Freeze?

Yes, I checked

[severinbeauvais]

Do you have a test that the value is True for all filings except Admin Freeze?

Yes, I checked

Great. How about a unit test?

[kzdev420]

Do you have a test that the value is True for all filings except Admin Freeze?

Yes, I checked

Great. How about a unit test?

I updated the unit test too. The current 4 failed cases don't relate to my updates.

[severinbeauvais]

Do you have a test that the value is True for all filings except Admin Freeze?

Yes, I checked

Great. How about a unit test?

I updated the unit test too. The current 4 failed cases don't relate to my updates.

I don't see a unit test that verifies that displayLedger is True for all filings except Admin Freeze...?

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[severinbeauvais]

Thanks for the extra unit test.

This looks good to me.

[vysakh-menon-aot]

@kzdev420 can you change this pr to ready for review?