Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17931 add Letter of Agm Extension PDFs #2332

Merged
merged 5 commits into from
Nov 28, 2023
Merged

17931 add Letter of Agm Extension PDFs #2332

merged 5 commits into from
Nov 28, 2023

Conversation

tshyun24
Copy link
Contributor

Issue #: /bcgov/entity#17931

Description of changes: Add 3 PDFs regarding first Agm Extension, final one and neither of them

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@tshyun24 tshyun24 self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #2332 (2bbb6cb) into main (79511cd) will decrease coverage by 0.99%.
Report is 37 commits behind head on main.
The diff coverage is 55.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2332      +/-   ##
==========================================
- Coverage   77.37%   76.38%   -0.99%     
==========================================
  Files         202      165      -37     
  Lines       11602    10218    -1384     
  Branches     1961     1722     -239     
==========================================
- Hits         8977     7805    -1172     
+ Misses       2043     1941     -102     
+ Partials      582      472     -110     
Flag Coverage Δ
entityfiler ?
legalapi 76.38% <55.21%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
legal-api/src/legal_api/config.py 95.16% <100.00%> (+0.28%) ⬆️
legal-api/src/legal_api/core/filing.py 86.55% <100.00%> (+0.04%) ⬆️
legal-api/src/legal_api/core/meta/filing.py 91.11% <ø> (ø)
legal-api/src/legal_api/models/__init__.py 100.00% <100.00%> (ø)
legal-api/src/legal_api/models/dc_definition.py 90.69% <100.00%> (ø)
...l-api/src/legal_api/models/dc_revocation_reason.py 100.00% <100.00%> (ø)
...s/v2/business/business_filings/business_filings.py 65.60% <100.00%> (+6.32%) ⬆️
legal-api/src/legal_api/services/authz.py 94.54% <ø> (ø)
...gal_api/services/filings/validations/alteration.py 83.01% <100.00%> (ø)
...al-api/src/legal_api/utils/legislation_datetime.py 84.12% <100.00%> (+0.79%) ⬆️
... and 11 more

... and 42 files with indirect coverage changes

@argush3
Copy link
Collaborator

argush3 commented Nov 27, 2023

Looks good!

Just the one last comment to address.

Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@chenhongjing chenhongjing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐱

@tshyun24 tshyun24 merged commit 35eab9f into bcgov:main Nov 28, 2023
8 of 9 checks passed
amanji pushed a commit to petridishdev/lear that referenced this pull request Nov 30, 2023
* add Letter of Agm Extension PDFs

* fix lint

* fix import order

* fix typo

* fix null in 'expireDateApprovedExt'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants