-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17931 add Letter of Agm Extension PDFs #2332
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
==========================================
- Coverage 77.37% 76.38% -0.99%
==========================================
Files 202 165 -37
Lines 11602 10218 -1384
Branches 1961 1722 -239
==========================================
- Hits 8977 7805 -1172
+ Misses 2043 1941 -102
+ Partials 582 472 -110
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Looks good! Just the one last comment to address. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐱
* add Letter of Agm Extension PDFs * fix lint * fix import order * fix typo * fix null in 'expireDateApprovedExt'
Issue #: /bcgov/entity#17931
Description of changes: Add 3 PDFs regarding first Agm Extension, final one and neither of them
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).