Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18370 Fix list of outputs AGM extension #2291

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

leodube-aot
Copy link
Collaborator

@leodube-aot leodube-aot commented Nov 3, 2023

Issue #: /bcgov/entity#18370

Description of changes:

  • Created initial template file for "Letter of AGM Extension"
  • Changed filing display name to "Request for AGM Extension"

NOTE: implementation and logic of the letter to be implemented by the agm extension outputs ticket bcgov/entity#17931

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@leodube-aot leodube-aot self-assigned this Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2291 (8bc67ac) into main (79511cd) will decrease coverage by 0.64%.
Report is 13 commits behind head on main.
The diff coverage is 48.97%.

@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
- Coverage   77.37%   76.74%   -0.64%     
==========================================
  Files         202      204       +2     
  Lines       11602    11836     +234     
  Branches     1961     1993      +32     
==========================================
+ Hits         8977     9083     +106     
- Misses       2043     2160     +117     
- Partials      582      593      +11     
Flag Coverage Δ
legalapi 76.11% <48.97%> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
legal-api/src/legal_api/config.py 95.16% <100.00%> (+0.28%) ⬆️
legal-api/src/legal_api/core/filing.py 86.55% <100.00%> (+0.04%) ⬆️
legal-api/src/legal_api/core/meta/filing.py 91.11% <ø> (ø)
legal-api/src/legal_api/models/__init__.py 100.00% <100.00%> (ø)
legal-api/src/legal_api/models/dc_definition.py 90.69% <100.00%> (ø)
legal-api/src/legal_api/services/authz.py 94.54% <ø> (ø)
...gal_api/services/filings/validations/alteration.py 83.01% <100.00%> (ø)
legal-api/src/legal_api/version.py 100.00% <100.00%> (ø)
..._services/entity-filer/src/entity_filer/version.py 100.00% <ø> (ø)
...l_api/models/dc_issued_business_user_credential.py 94.44% <94.44%> (ø)
... and 7 more

@argush3
Copy link
Collaborator

argush3 commented Nov 3, 2023

Can we add the corresponding tests for paid and completed status to this test.

I had forgot about this when reviewing @tshyun24's PR on agmLocationChange document list.

Can you add 2 tests for agmLocationChange too while you're at it?

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@argush3 argush3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks for adding the tests!

Copy link
Collaborator

@chenhongjing chenhongjing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😺

@leodube-aot leodube-aot merged commit 384368e into bcgov:main Nov 7, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants