Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Feature Flag Legacy Details #2044

Merged
merged 2 commits into from
Feb 19, 2025
Merged

feat: Feature Flag Legacy Details #2044

merged 2 commits into from
Feb 19, 2025

Conversation

dhaselhan
Copy link
Collaborator

  • Remove no longer used notification flag
  • Default to true on localhost

@dhaselhan
feat: Feature Flag Legacy Details
d7bfa7c 
* Remove no longer used notification flag
* Default to true on localhost
@dhaselhan dhaselhan requested a review from AlexZorkin February 18, 2025 21:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

Frontend Test Results

  1 files  ±0  130 suites  ±0   49s ⏱️ ±0s
448 tests ±0  428 ✅ ±0  20 💤 ±0  0 ❌ ±0 
450 runs  ±0  430 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit d98ec8e. ± Comparison against base commit f01743e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

Backend Test Results

585 tests  ±0   585 ✅ ±0   2m 22s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit d98ec8e. ± Comparison against base commit f01743e.

♻️ This comment has been updated with latest results.

AlexZorkin
AlexZorkin approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
please followup with our devops lead to implement this in the deployment config for production env. test can just leave this feature enabled as well.

@dhaselhan dhaselhan merged commit 50adc9e into release-1.0.0 Feb 19, 2025
1 check passed
@dhaselhan dhaselhan deleted the feat/daniel-add-legacy-flag-2040 branch February 19, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexZorkin AlexZorkin AlexZorkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaselhan @AlexZorkin