Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add transfer_comment Table and Migrate Existing Comments #1952

Merged

Conversation

hamed-valiollahi
Copy link
Collaborator

@hamed-valiollahi hamed-valiollahi commented Feb 7, 2025

This PR adds the new transfer_comment table and migrates existing comment fields from the transfer table.

Copy link

github-actions bot commented Feb 7, 2025

Frontend Test Results

  1 files  ±0  125 suites  ±0   46s ⏱️ -3s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 9963f6e. ± Comparison against base commit 5211e12.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 7, 2025

Backend Test Results

530 tests  ±0   530 ✅ ±0   1m 49s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 9963f6e. ± Comparison against base commit 5211e12.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much more elegant, thank you for the refactor.

@hamed-valiollahi hamed-valiollahi merged commit a3052ab into release-1.0.0 Feb 7, 2025
11 checks passed
@hamed-valiollahi
Copy link
Collaborator Author

This is much more elegant, thank you for the refactor.

Thanks for guiding me! Your feedback really helped me improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants