Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Export and Template for FSE #1948

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

dhaselhan
Copy link
Collaborator

  • Add new Export for FSE to produce templates and download data
  • Add data_validators to the spreadsheet builder as well as the ability to set column type
  • Add new routes for the new API endpoints and add download button to the front end
  • Add tests to FSE

@dhaselhan dhaselhan requested a review from AlexZorkin February 7, 2025 00:12
Copy link

github-actions bot commented Feb 7, 2025

Frontend Test Results

  1 files  ±0  129 suites  ±0   48s ⏱️ ±0s
444 tests ±0  424 ✅ ±0  20 💤 ±0  0 ❌ ±0 
446 runs  ±0  426 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit d9fb220. ± Comparison against base commit 55937ff.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 7, 2025

Backend Test Results

543 tests  +13   543 ✅ +13   2m 8s ⏱️ +21s
  1 suites ± 0     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit d9fb220. ± Comparison against base commit 55937ff.

♻️ This comment has been updated with latest results.

@dhaselhan dhaselhan force-pushed the feat/daniel-fse-download-1920 branch 2 times, most recently from 5b0dd07 to 27921b6 Compare February 10, 2025 20:09
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The power of openpyxl on full display. Dropdown options in the template excel file are great. Only addition that would be nice is to add a loading spinner to the download button after you click it. The template creation takes a number of seconds and will leave the user confused as to whether the download is happening.

@dhaselhan
Copy link
Collaborator Author

The power of openpyxl on full display. Dropdown options in the template excel file are great. Only addition that would be nice is to add a loading spinner to the download button after you click it. The template creation takes a number of seconds and will leave the user confused as to whether the download is happening.

The worst part is the slowdown is applying the formatting to all the empty cells in case they don't copy/paste. It sets formulas for the first 10,000 rows which made the download go from instant -> few seconds.

@AlexZorkin
Copy link
Collaborator

The power of openpyxl on full display. Dropdown options in the template excel file are great. Only addition that would be nice is to add a loading spinner to the download button after you click it. The template creation takes a number of seconds and will leave the user confused as to whether the download is happening.

The worst part is the slowdown is applying the formatting to all the empty cells in case they don't copy/paste. It sets formulas for the first 10,000 rows which made the download go from instant -> few seconds.

Gotcha, maybe we ask what the 'average' amount of rows an org would be inputting and we use that. If we can get away with 1000 that might be a faster download?

* Add new Export for FSE to produce templates and download data
* Add data_validators to the spreadsheet builder as well as the ability to set column type
* Add new routes for the new API endpoints and add download button to the front end
* Add tests to FSE
* Fix BCButton to have a dark spinner when using outlined which has a white background
@dhaselhan dhaselhan force-pushed the feat/daniel-fse-download-1920 branch from 27921b6 to d9fb220 Compare February 11, 2025 01:11
@dhaselhan
Copy link
Collaborator Author

dhaselhan commented Feb 11, 2025

Gotcha, maybe we ask what the 'average' amount of rows an org would be inputting and we use that. If we can get away with 1000 that might be a faster download?

I asked Lindsy and the hard theoretical limit would be 10,000. I've added a loading spinner but Ill bring this up tomorrow at standup and see if we can drop it in my next MR.

@dhaselhan dhaselhan requested a review from AlexZorkin February 11, 2025 01:12
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ty 👍

@dhaselhan dhaselhan merged commit 84e73be into release-1.0.0 Feb 11, 2025
1 check passed
@dhaselhan dhaselhan deleted the feat/daniel-fse-download-1920 branch February 11, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants