-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Export and Template for FSE #1948
Conversation
dhaselhan
commented
Feb 7, 2025
- Add new Export for FSE to produce templates and download data
- Add data_validators to the spreadsheet builder as well as the ability to set column type
- Add new routes for the new API endpoints and add download button to the front end
- Add tests to FSE
5b0dd07
to
27921b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The power of openpyxl on full display. Dropdown options in the template excel file are great. Only addition that would be nice is to add a loading spinner to the download button after you click it. The template creation takes a number of seconds and will leave the user confused as to whether the download is happening.
The worst part is the slowdown is applying the formatting to all the empty cells in case they don't copy/paste. It sets formulas for the first 10,000 rows which made the download go from instant -> few seconds. |
Gotcha, maybe we ask what the 'average' amount of rows an org would be inputting and we use that. If we can get away with 1000 that might be a faster download? |
* Add new Export for FSE to produce templates and download data * Add data_validators to the spreadsheet builder as well as the ability to set column type * Add new routes for the new API endpoints and add download button to the front end * Add tests to FSE
* Fix BCButton to have a dark spinner when using outlined which has a white background
27921b6
to
d9fb220
Compare
I asked Lindsy and the hard theoretical limit would be 10,000. I've added a loading spinner but Ill bring this up tomorrow at standup and see if we can drop it in my next MR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ty 👍