Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1925: Supporting Documents Accordion Displays Even When No Documents Are Uploaded #1933

Merged

Conversation

areyeslo
Copy link
Collaborator

@areyeslo areyeslo commented Feb 6, 2025

When there is no documents, Supporting Documents section should not appear. If there is at least one doc, then show the accordion opened:

image image

@areyeslo areyeslo marked this pull request as ready for review February 6, 2025 20:21
Copy link

github-actions bot commented Feb 6, 2025

Frontend Test Results

  1 files  ±0  125 suites  ±0   47s ⏱️ -2s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 1f8884a. ± Comparison against base commit 2515d43.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 6, 2025

Backend Test Results

526 tests  ±0   526 ✅ ±0   1m 50s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 1f8884a. ± Comparison against base commit 2515d43.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@areyeslo areyeslo merged commit 89f28c1 into release-1.0.0 Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants