Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Early issuance flag #1915

Merged
merged 2 commits into from
Feb 7, 2025
Merged

feat: Add Early issuance flag #1915

merged 2 commits into from
Feb 7, 2025

Conversation

dhaselhan
Copy link
Collaborator

  • Add new column on org to store
  • Add update/create logic to API
  • Add form field and send to backend

@dhaselhan dhaselhan requested a review from AlexZorkin February 4, 2025 22:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Frontend Test Results

  1 files  ±0  125 suites  ±0   47s ⏱️ -1s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 322a91f. ± Comparison against base commit 7e9a74a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Backend Test Results

530 tests  ±0   530 ✅ ±0   1m 49s ⏱️ -8s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 322a91f. ± Comparison against base commit 7e9a74a.

♻️ This comment has been updated with latest results.

@dhaselhan dhaselhan force-pushed the feat/daniel-add-early-issuance-1851 branch from ab38dc8 to 05f0535 Compare February 4, 2025 22:19
AlexZorkin
AlexZorkin reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that one debugger statement to remove

AlexZorkin
AlexZorkin requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to remove that debugger statement then all good

@dhaselhan
feat: Add Early issuance flag
b2d2ad3 
* Add new column on org to store
* Add update/create logic to API
* Add form field and send to backend
@dhaselhan dhaselhan force-pushed the feat/daniel-add-early-issuance-1851 branch from 05f0535 to b2d2ad3 Compare February 7, 2025 00:42
@dhaselhan
Copy link
Collaborator Author

just to remove that debugger statement then all good

Removed

prv-proton
prv-proton approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

areyeslo
areyeslo approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@areyeslo areyeslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

AlexZorkin
AlexZorkin approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhaselhan dhaselhan merged commit 7e49fdb into release-1.0.0 Feb 7, 2025
1 check passed
@dhaselhan dhaselhan deleted the feat/daniel-add-early-issuance-1851 branch February 7, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areyeslo areyeslo areyeslo approved these changes

@AlexZorkin AlexZorkin AlexZorkin approved these changes

@prv-proton prv-proton prv-proton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhaselhan @areyeslo @AlexZorkin @prv-proton