Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: LCFS - Migrate Schedule B Records from TFRS to Fuel Supply #1908

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

prv-proton
Copy link
Collaborator

Copy link

github-actions bot commented Feb 4, 2025

Frontend Test Results

  1 files  ±0  125 suites  ±0   46s ⏱️ -1s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit b664889. ± Comparison against base commit aebb469.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 4, 2025

Backend Test Results

530 tests  ±0   530 ✅ ±0   1m 49s ⏱️ -17s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit b664889. ± Comparison against base commit aebb469.

♻️ This comment has been updated with latest results.

LIMIT 1) as ci_limit,
CASE
WHEN dt.the_type = 'Alternative' THEN crsbr.intensity
WHEN dt.the_type = 'GHGenius' THEN crsbr.intensity -- TODO fix intensity to extract from Schedule-D sheets
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the part left you are referring?
Identify and process Schedule D records, setting provision type to GHGenius modelled:
id|description |
--+------------------------------+
5|GHGenius modelled |
Can you please elaborate?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @areyeslo , as discussed in dev session we'll be having a different ticket to handle GHGenius

@prv-proton prv-proton requested a review from areyeslo February 7, 2025 20:35
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we will handle the ghgenius/schedule d updates in a separate ticket.

@prv-proton prv-proton merged commit 5f5bfcf into release-1.0.0 Feb 7, 2025
7 checks passed
@prv-proton prv-proton deleted the feat/prashanth-migrate-sch-b-1554 branch February 7, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants