Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 2 Bug Fixes #1898

Merged
merged 2 commits into from
Feb 3, 2025
Merged

fix: 2 Bug Fixes #1898

merged 2 commits into from
Feb 3, 2025

Conversation

dhaselhan
Copy link
Collaborator

  • Pass in request.user instead of trying to read it from self
  • The FE for Compliance Report was updated to show nickname in the Type column but the filter was not updated

@dhaselhan
fix: 2 Bug Fixes
fc785f2 
* Pass in request.user instead of trying to read it from self
* The FE for Compliance Report was updated to show nickname in the Type column but the filter was not updated
@dhaselhan dhaselhan requested a review from AlexZorkin January 31, 2025 23:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

Frontend Test Results

  1 files  ±0  125 suites  ±0   46s ⏱️ -2s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 016a1c2. ± Comparison against base commit 6140dc1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

Backend Test Results

524 tests  ±0   524 ✅ ±0   1m 51s ⏱️ -3s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 016a1c2. ± Comparison against base commit 6140dc1.

♻️ This comment has been updated with latest results.

AlexZorkin
AlexZorkin approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhaselhan dhaselhan merged commit e035a9d into release-1.0.0 Feb 3, 2025
1 check passed
@dhaselhan dhaselhan deleted the fix/daniel-fixes-1871 branch February 3, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexZorkin AlexZorkin AlexZorkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaselhan @AlexZorkin