Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't fire refresh queries when changing compliance report status #1897

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

dhaselhan
Copy link
Collaborator

  • New code navigates to the main listing, so we dont need to refresh all the sub-data
  • Firing the refresh in the case of return to supplier was resulting in a 403

* New code navigates to the main listing, so we dont need to refresh all the sub-data
* Firing the refresh in the case of return to supplier was resulting in a 403
@dhaselhan dhaselhan requested a review from AlexZorkin January 31, 2025 22:38
Copy link

github-actions bot commented Jan 31, 2025

Frontend Test Results

  1 files  ±0  125 suites  ±0   46s ⏱️ -1s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 483adf8. ± Comparison against base commit a73fc53.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 31, 2025

Backend Test Results

524 tests  ±0   524 ✅ ±0   1m 53s ⏱️ +4s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 483adf8. ± Comparison against base commit a73fc53.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍

@dhaselhan dhaselhan merged commit 6140dc1 into release-1.0.0 Feb 3, 2025
1 check passed
@dhaselhan dhaselhan deleted the fix/daniel-fix-403-1869 branch February 3, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants