Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/read proponents for opportunity #482

Merged
merged 19 commits into from
Jul 10, 2024

Conversation

IanFonzie
Copy link
Collaborator

This PR closes issue: DMM-137, DMM-475, DMM-476

Includes tests? Y
Updated docs? N

Proposed changes:

  • Knex returned different types for the counter queries after upgrading; modify query to conform with new types (undocumented bug)
  • Allow reading of inactive orgs and affiliations when archiving organizations (undocumented bug)
  • Read inactive proponents for CWU proposals (DMM-475)
  • Use SWU/TWU organization if it exists for proposal review tab (DMM-476)
  • Remove TWU Banner

Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@IanFonzie IanFonzie merged commit fd63c92 into development Jul 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant