Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/toggle admin status #429

Merged
merged 23 commits into from
Nov 7, 2023
Merged

Feat/toggle admin status #429

merged 23 commits into from
Nov 7, 2023

Conversation

IanFonzie
Copy link
Collaborator

@IanFonzie IanFonzie commented Oct 31, 2023 •
edited
Loading

This PR closes issue: [DMM-240, DMM-265, DMM-266, DMM-267, DMM-268, DMM-269, DMM-270, DMM-271]

Includes tests? [N]
Updated docs? [N]

Proposed changes:

  • Modifies Affiliations update endpoint to accept multiple types of update requests
  • Adds a new "updateAdminStatus" update request type
  • Adds a checkbox to each member on the team team page that can only be used according to the user stories referenced in the issues above
  • Display confirmation modal when granting admin rights

@IanFonzie IanFonzie requested review from bdolor and removed request for dhruvio and sutherlanda November 2, 2023 16:19
bdolor
bdolor requested changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@bdolor bdolor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently, vendor admins can't see the team list due to permission constraints, nor do they have a way to navigate to the teams list to make modifications as per DMM-268/267. Once permissions are fixed they can remove their own Admin functionality which is likely undesirable.

src/front-end/typescript/lib/pages/organization/edit/tab/team.tsx Show resolved Hide resolved
src/front-end/typescript/lib/pages/user/profile/tab/organizations.tsx Show resolved Hide resolved
src/back-end/lib/permissions.ts Outdated Show resolved Hide resolved
@IanFonzie
Copy link
Collaborator Author

@bdolor, Addressed your changes and also added in support for DMM-240. It's not addressed in the user stories but 85c9a86 makes org links clickable for admins from the dashboard. It might be a good idea for us to go over those changes together as a sanity check.

@IanFonzie IanFonzie requested a review from bdolor November 3, 2023 23:23
@IanFonzie IanFonzie requested a review from bdolor November 7, 2023 00:06
@IanFonzie IanFonzie merged commit bc8ba4d into development Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdolor bdolor bdolor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanFonzie @bdolor