Skip to content

Commit

Permalink
fix: banner image should not use a Link to /
Browse files Browse the repository at this point in the history
This will ensure that logged in users are redirected to the appropriate landing route
  • Loading branch information
matthieu-foucault committed Nov 26, 2021
1 parent f69aa5f commit 7e8706d
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions app/components/Layout/Navigation.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import Link from "next/link";
import Image from "next/image";
import Button from "@button-inc/bcgov-theme/Button";
import { BaseNavigation } from "@button-inc/bcgov-theme/Navigation";
Expand Down Expand Up @@ -31,16 +30,19 @@ const Navigation: React.FC<Props> = ({
<BaseNavigation>
<BaseHeader>
<BaseHeader.Group className="banner">
<Link href="/">
<a>
<Image
src="/img/BCID_CleanBC_rev_tagline_colour.svg"
alt="logo for Province of British Columbia CleanBC"
height={50}
width={300}
/>
</a>
</Link>
{/*
We don't want a front end navigation here,
to ensure that a back-end redirect is performed when clicking on the banner image
*/}
{/* eslint-disable-next-line @next/next/no-html-link-for-pages*/}
<a href="/">
<Image
src="/img/BCID_CleanBC_rev_tagline_colour.svg"
alt="logo for Province of British Columbia CleanBC"
height={50}
width={300}
/>
</a>
</BaseHeader.Group>
<BaseHeader.Item collapse="900">
<h1>{title}</h1>
Expand Down

0 comments on commit 7e8706d

Please sign in to comment.