significant individuals filing store #62
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage ? 87.57%
=======================================
Files ? 20
Lines ? 950
Branches ? 33
=======================================
Hits ? 832
Misses ? 86
Partials ? 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-62-goo6ef6x.web.app |
| @@ -8,25 +8,23 @@ | |||
| <IndividualPersonAddNew /> | |||
| </div> | |||
| </div> | |||
| <IndividualPersonSummaryTable class="mt-5" :individuals="individuals" /> | |||
| <IndividualPersonSummaryTable class="mt-5" :individuals="currentSIFiling.significantIndividuals || []" /> | |||
There was a problem hiding this comment.
Is it just the ones being currently filed (will current filing contain already existing ones ?)
There was a problem hiding this comment.
yeah when the user starts the filing it will auto populate with their existing ones
There was a problem hiding this comment.
I will mock that out as part of bcgov/entity#18664
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
kialj876
force-pushed
the
18677-integrate-store-for-SI-filing
branch
from
fb2aba9
to
74716db
Compare
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-62-goo6ef6x.web.app |
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
|
/gcbrun |
*Issue:*bcgov/entity#18677
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).