18162 AGM Location Change - part 2 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
kzdev420
approved these changes
Oct 23, 2023
argush3
approved these changes
Oct 23, 2023
thorwolpert
reviewed
Oct 25, 2023
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
thorwolpert
approved these changes
Oct 26, 2023
| }, | ||
| "agmLocation": { | ||
| "type": "string", | ||
| "maxLength": 100 |
There was a problem hiding this comment.
if someone does type in address, this is too short to hold the data we have for addresses. and that's assuming they use the codes for state/prov & country and don't spell them out.
JazzarKarim
pushed a commit
to JazzarKarim/business-schemas
that referenced
this pull request
Jan 31, 2024
* 18162 AGM Location Change II Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * fix Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * update max len of AGM location Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * fix test Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> --------- Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#18162
Description of changes:
reasonfieldagmLocationfieldBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).