-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17796 Allow firm registration for single name user/account #144
Conversation
Can you update the version https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/version.py#L26 |
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names examples break some fundamental rules.
The natural person should only require a lastName, leave out the complexity.
"properties": { | ||
"firstName": { "minLength": 1 } | ||
}, | ||
"required": ["firstName"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably change the schema to allow a null firstName in all circumstances.
@@ -958,8 +958,8 @@ | |||
{ | |||
'officer': { | |||
'id': 2, | |||
'firstName': '', | |||
'lastName': '', | |||
'firstName': 'Peter', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't be able to have name fields and organizationName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
* 17796 Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * fix some tests Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * fix-2 Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * update version = 2.18.12 Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * update required fields Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * fix-3 Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * update version=2.18.13 Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> --------- Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Issue #: /bcgov/entity#17796
Description of changes:
person
person
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).