Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16967 Admin Freeze should not show on ledger #603

Merged
merged 9 commits into from
Jan 4, 2024
Merged

16967 Admin Freeze should not show on ledger #603

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8a0eaf9
hide admin_freeze filing
kzdev420 Jan 3, 2024
6e93d9e
update feature
kzdev420 Jan 4, 2024
453f342
fix small
kzdev420 Jan 4, 2024
790dcd8
fix lint issue
kzdev420 Jan 4, 2024
f665f08
update feature
kzdev420 Jan 4, 2024
c68af03
update test and app version
kzdev420 Jan 4, 2024
dd2c156
fix lint issue
kzdev420 Jan 4, 2024
7031e44
Merge branch 'main' of https://github.com/kzdev420/business-filings-u…
kzdev420 Jan 4, 2024
470c267
update app version
kzdev420 Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-filings-ui",
"version": "7.0.29",
"version": "7.0.30",
"private": true,
"appName": "Filings UI",
"sbcName": "SBC Common Components",
Expand Down
1 change: 1 addition & 0 deletions src/interfaces/api-filing-interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export interface ApiFilingIF {
commentsCount: number
commentsLink: string // URL to fetch this filing's comments
displayName: string
displayLedger: boolean // Display on the ledger
documentsLink: string // URL to fetch this filing's documents
effectiveDate: FormattedDateTimeGmt
filingId: number
Expand Down
4 changes: 4 additions & 0 deletions src/stores/filingHistoryListStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ export const useFilingHistoryListStore = defineStore('filingHistoryList', {
// eslint-disable-next-line no-console
console.log('Invalid filing =', filing)
return false
} else if (!filing.displayLedger) {
// eslint-disable-next-line no-console
console.log('Not shown filing on the ledger =', filing)
return false
}
return true
})
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/EntityHeader.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ describe('Entity Header - data', () => {
rootStore.setTasks([])
filingHistoryListStore.setFilings([
{
displayLedger: true,
displayName: 'BC Limited Company Amalgamation Application - Regular',
effectiveDate: '2019-06-02 19:22:59 GMT',
name: FilingTypes.AMALGAMATION_APPLICATION,
Expand Down Expand Up @@ -197,6 +198,7 @@ describe('Entity Header - data', () => {
rootStore.setTasks([])
filingHistoryListStore.setFilings([
{
displayLedger: true,
displayName: 'BC Limited Company Amalgamation Application - Regular',
effectiveDate: '2019-06-02 19:22:59 GMT',
name: FilingTypes.AMALGAMATION_APPLICATION,
Expand Down Expand Up @@ -224,6 +226,7 @@ describe('Entity Header - data', () => {
rootStore.setTasks([])
filingHistoryListStore.setFilings([
{
displayLedger: true,
displayName: 'BC Limited Company Amalgamation Application - Regular',
effectiveDate: '2019-06-02 19:22:59 GMT',
name: FilingTypes.AMALGAMATION_APPLICATION,
Expand Down Expand Up @@ -251,6 +254,7 @@ describe('Entity Header - data', () => {
rootStore.setTasks([])
filingHistoryListStore.setFilings([
{
displayLedger: true,
displayName: 'BC Limited Company Amalgamation Application - Regular',
effectiveDate: '2019-06-02 19:22:59 GMT',
name: FilingTypes.AMALGAMATION_APPLICATION,
Expand Down
Loading
Loading