generated from bcgov/bcrs-template-ui
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18805+18979 Amalgamate Button + Moved to amalgamationApplication + Selection Panel #600
Merged
JazzarKarim
merged 10 commits into
bcgov:main
from
JazzarKarim:18805-amalgamation-selection-panel
Dec 18, 2023
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5306002
Implemented Amalgamate button + changed amalgamation to amalgamationA…
JazzarKarim 7b1f81b
Implemented Amalgamation Selection Panel
JazzarKarim 97eeae2
Updated package version after rebase
JazzarKarim 3327cd9
Added safe value + deleted unnecessary comment
JazzarKarim 91d9bb6
Updated in response to Sev's comments
JazzarKarim 085f073
another small update in response to Sev's comment
JazzarKarim 56b746e
missing import
JazzarKarim f34bc27
small updates in response to Sev's comment
JazzarKarim 49445a2
removed unused imports
JazzarKarim fc6c316
changed disabled condition
JazzarKarim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
import Dashboard from '@/views/Dashboard.vue' | ||
import AgmExtension from '@/views/AgmExtension.vue' | ||
import AgmLocationChg from '@/views/AgmLocationChg.vue' | ||
import AmalgamationSelection from '@/views/AmalgamationSelection.vue' | ||
import AnnualReport from '@/views/AnnualReport.vue' | ||
import StandaloneDirectorsFiling from '@/views/StandaloneDirectorsFiling.vue' | ||
import StandaloneOfficeAddressFiling from '@/views/StandaloneOfficeAddressFiling.vue' | ||
|
@@ -53,6 +54,22 @@ export default [ | |
] | ||
} | ||
}, | ||
{ | ||
path: '/amalgamation-selection', | ||
name: Routes.AMALGAMATION_SELECTION, | ||
component: AmalgamationSelection, | ||
meta: { | ||
requiresAuth: true, | ||
breadcrumb: [ | ||
{ | ||
text: 'Amalgamation Selection', | ||
disabled: false, | ||
exact: true, | ||
to: { name: Routes.AMALGAMATION_SELECTION } | ||
} | ||
] | ||
} | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It makes sense to me to update the breadcrumb when they're on this panel (view) 👍 |
||
{ | ||
path: '/annual-report', | ||
name: Routes.ANNUAL_REPORT, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If business is historical, we won't show the button.