-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add detail comment (part 2) #15
Conversation
b2b285e
to
07935ca
Compare
7082bce
to
9fe1e0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had a few comments/questions, nothing that would block this tho! Good clean up in the unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Styling: I notice you put your methods mostly on newlines, which I do as well. I found that easier to read than some of the other sections. What do you think about encouraging others to use that style?
- added Add Comment Dialog unit tests - added Detail Comment unit tests - refactored Directors unit tests to not use setTimeout() - fixed filing save tests (missing 'get tasks') - cleaned up other unit tests - added Detail Comment autofocus prop - display app version on startup to console - removed obsolete hard-coded entity type (code still not in use) - ensures comments are sorted by timestamp
ee8ed51
to
0d3d073
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
* oracledb not starting Signed-off-by: Kial Jinnah <kialj876@gmail.com> * working dockerfile Signed-off-by: Kial Jinnah <kialj876@gmail.com> * oracle running in openshift Signed-off-by: Kial Jinnah <kialj876@gmail.com> * cleaned up dockerfile/echo stmnts Signed-off-by: Kial Jinnah <kialj876@gmail.com> * deployment config added Signed-off-by: Kial Jinnah <kialj876@gmail.com> * readme for oracle container Signed-off-by: Kial Jinnah <kialj876@gmail.com>
completed files for build/deploy from GH Actions
* initial commit * Updated for initial PR * Removed padding class * Pr Comments Update * Initial Commit. Form Implementation * Wrap up NameRequest UI correction * import clean up * Console clean up * Pr Updates
Issue #: /bcgov/entity#2719
Description of changes:
display app version on startup to consoledeletedBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).