Skip to content

Commit

Permalink
16967 Admin Freeze should not show on ledger (#603)
Browse files Browse the repository at this point in the history
* hide admin_freeze filing

* update feature

* fix small

* fix lint issue

* update feature

* update test and app version

* fix lint issue

* update app version
  • Loading branch information
kzdev420 committed Jan 4, 2024
1 parent d710264 commit 48679a2
Show file tree
Hide file tree
Showing 8 changed files with 140 additions and 3 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-filings-ui",
"version": "7.0.30",
"version": "7.0.31",
"private": true,
"appName": "Filings UI",
"sbcName": "SBC Common Components",
Expand Down
1 change: 1 addition & 0 deletions src/interfaces/api-filing-interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export interface ApiFilingIF {
commentsCount: number
commentsLink: string // URL to fetch this filing's comments
displayName: string
displayLedger: boolean // Display on the ledger
documentsLink: string // URL to fetch this filing's documents
effectiveDate: FormattedDateTimeGmt
filingId: number
Expand Down
4 changes: 4 additions & 0 deletions src/stores/filingHistoryListStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ export const useFilingHistoryListStore = defineStore('filingHistoryList', {
// eslint-disable-next-line no-console
console.log('Invalid filing =', filing)
return false
} else if (!filing.displayLedger) {
// eslint-disable-next-line no-console
console.log('Not shown filing on the ledger =', filing)
return false
}
return true
})
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/EntityHeader.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ describe('Entity Header - data', () => {
rootStore.setTasks([])
filingHistoryListStore.setFilings([
{
displayLedger: true,
displayName: 'BC Limited Company Amalgamation Application - Regular',
effectiveDate: '2019-06-02 19:22:59 GMT',
name: FilingTypes.AMALGAMATION_APPLICATION,
Expand Down Expand Up @@ -197,6 +198,7 @@ describe('Entity Header - data', () => {
rootStore.setTasks([])
filingHistoryListStore.setFilings([
{
displayLedger: true,
displayName: 'BC Limited Company Amalgamation Application - Regular',
effectiveDate: '2019-06-02 19:22:59 GMT',
name: FilingTypes.AMALGAMATION_APPLICATION,
Expand Down Expand Up @@ -224,6 +226,7 @@ describe('Entity Header - data', () => {
rootStore.setTasks([])
filingHistoryListStore.setFilings([
{
displayLedger: true,
displayName: 'BC Limited Company Amalgamation Application - Regular',
effectiveDate: '2019-06-02 19:22:59 GMT',
name: FilingTypes.AMALGAMATION_APPLICATION,
Expand Down Expand Up @@ -251,6 +254,7 @@ describe('Entity Header - data', () => {
rootStore.setTasks([])
filingHistoryListStore.setFilings([
{
displayLedger: true,
displayName: 'BC Limited Company Amalgamation Application - Regular',
effectiveDate: '2019-06-02 19:22:59 GMT',
name: FilingTypes.AMALGAMATION_APPLICATION,
Expand Down
Loading

0 comments on commit 48679a2

Please sign in to comment.