Show Descriptions in Autocomplete Options #1497
Conversation
…d to the use of ListItemText
…ated UserRoleSelector
…eld for consistency. Is there a context to use variableSize?
|
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1497 +/- ##
==========================================
+ Coverage 45.92% 47.49% +1.57%
==========================================
Files 907 926 +19
Lines 23537 24022 +485
Branches 3492 3570 +78
==========================================
+ Hits 10809 11409 +600
+ Misses 12136 11993 -143
- Partials 592 620 +28 ☔ View full report in Codecov by Sentry. |
|
| @@ -122,6 +122,9 @@ GET.apiDoc = { | |||
| }, | |||
| name: { | |||
| type: 'string' | |||
| }, | |||
| description: { | |||
| type: 'string' | |||
There was a problem hiding this comment.
If the description can be null in the database, you should include nullable: true in the description object here. Otherwise the request would fail for what the database considers valid data.
(Disregard if the description field of the type database table has a not null constraint.)
| @@ -80,6 +81,14 @@ const EditSurveyForm = < | |||
| .concat(SurveyPartnershipsFormYupSchema) | |||
| .concat(SpeciesYupSchema); | |||
|
|
|||
| // Add this transformer function | |||
| const transformSurveyJobs = (jobs: typeof codes.survey_jobs): IGetAllCodeSetsResponse['project_roles'] => { | |||
There was a problem hiding this comment.
I don't think this is doing anything?
| system_user_id: 2, | ||
| user_identifier: 'myidirbossagain', | ||
| role_names: ['role 1', 'role 4'] | ||
| // ...existing test setup... |
| @@ -12,7 +12,6 @@ | |||
| "forceConsistentCasingInFileNames": true, | |||
| "noImplicitThis": true, | |||
| "noImplicitAny": true, | |||
| "suppressImplicitAnyIndexErrors": true, | |||
There was a problem hiding this comment.
This controls some typescript settings that we want to keep, so we shouldn't be modifying this file.
| import { Knex } from 'knex'; | ||
|
|
||
| /** | ||
| * Add new columns to survey_sample_period table |
mauberti-bc
changed the title
mauberti-bc
added
Early Feedback Welcome
Links to Jira Tickets
NA.
ADDING DESCRIPTIONS TO VARIOUS DROPDOWNS IN THE APP.
New Migration created for adding description values, where missing.
Added descriptions for Project roles, Survey roles, Purpose and Methodology form (Collected data & Ecological concepts of interest) and Site Selection Strategy.
Note, I had to change some tests as they were failing.