Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Species' Ecological Units on Standards Page #1484

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

AMEIJER1
Copy link
Collaborator

@AMEIJER1 AMEIJER1 commented Feb 7, 2025

Description of Changes

  • made changes to backend critterbase api service to allow for passing of ecological unit categories
  • updated standards page to have an ecological units tab under species, and to return the ecological categories (but not yet the category options)

Testing Notes

  • have not yet hooked up ecological unit options, Macgregor mentioned critterbase may need to be updated prior to continuing this ticket (critterbase updated to return all values at once?)

@AMEIJER1 AMEIJER1 added Do Not Merge PR should not be merged Not Ready For Review Addressing feedback and/or refactoring labels Feb 7, 2025
@AMEIJER1 AMEIJER1 requested a review from mauberti-bc February 7, 2025 01:14
Copy link

sonarqubecloud bot commented Feb 7, 2025

@mauberti-bc mauberti-bc changed the title Updating standards page to display ecological units by tsn Include Species' Ecological Units on Standards Page Feb 7, 2025
nullable: true
},
itis_tsn: {
type: 'integer'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: minimum 1

label={category.category_name}
subtitle={category.description}
colour={grey[100]}>
{/* <Stack gap={2} my={2}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We can drop this deprecated code if it is not needed anymore

@@ -141,6 +141,30 @@ GET.apiDoc = {
}
}
},
ecologicalUnits: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Is this intended to be the Collection Categories ('Population Unit'...) or is this supposed to be Collection units ('Telkwa'...)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're wanting it to pull collection categories (population unit for example), and then the accordion would expand to show the collection units (telkwa) - but I think currently there is no API request that returns both for a species so Macgregor mentioned there may need to be some updates to critterbase before we can finish this ticket. Currently the UI is only displaying a card for categories, with no collection unit options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge PR should not be merged Not Ready For Review Addressing feedback and/or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants