-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Species' Ecological Units on Standards Page #1484
base: dev
Are you sure you want to change the base?
Conversation
Openshift URLs for the PR Deployment: |
|
nullable: true | ||
}, | ||
itis_tsn: { | ||
type: 'integer' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: minimum 1
label={category.category_name} | ||
subtitle={category.description} | ||
colour={grey[100]}> | ||
{/* <Stack gap={2} my={2}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We can drop this deprecated code if it is not needed anymore
@@ -141,6 +141,30 @@ GET.apiDoc = { | |||
} | |||
} | |||
}, | |||
ecologicalUnits: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Is this intended to be the Collection Categories
('Population Unit'...) or is this supposed to be Collection units
('Telkwa'...)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're wanting it to pull collection categories (population unit for example), and then the accordion would expand to show the collection units (telkwa) - but I think currently there is no API request that returns both for a species so Macgregor mentioned there may need to be some updates to critterbase before we can finish this ticket. Currently the UI is only displaying a card for categories, with no collection unit options.
Description of Changes
Testing Notes