Changing request timeout to infinite for file upload #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
added 2 commits
March 22, 2023 14:31
bcgv123
force-pushed
the
fix/3139-big-file-upload-timeout
branch
from
12509c2 to
50326c6
Compare
…tion and default one.
jujaga
reviewed
Mar 23, 2023
|
|
||
| /** | ||
| * @function comsAxios | ||
| * Returns an Axios instance for the COMS API | ||
| * @param {number} [timeout=10000] Number of milliseconds before timing out the request | ||
| Returns an Axios instance for the COMS API |
There was a problem hiding this comment.
Looks like a potential indentation issue in the git diff here?
…d, and fixing indentation.
jujaga
approved these changes
Mar 23, 2023
kamorel
reviewed
Mar 23, 2023
frontend/src/store/objectStore.ts
Outdated
| @@ -8,6 +8,7 @@ import { partition } from '@/utils/utils'; | |||
|
|
|||
| import type { Ref } from 'vue'; | |||
| import type { COMSObject, ObjectSearchPermissionsOptions } from '@/types'; | |||
| import type { AxiosRequestConfig } from 'axios'; | |||
There was a problem hiding this comment.
External type import. Should come before vue import.
kamorel
reviewed
Mar 23, 2023
| @@ -44,7 +44,8 @@ const onUpload = async (event: any) => { | |||
| await Promise.allSettled( | |||
| event.files.map(async (file: File) => { | |||
| try { | |||
| await objectStore.createObject(file, bucketId); | |||
| //infinite timeout for big files upload to avoid timeout error | |||
There was a problem hiding this comment.
Style: missing space after // and capitalization
kamorel
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3139? Changed the number of milliseconds before timing out the request for file upload only, to infinitive. Adding timeout as input argument at service/store layer, if not passed in defaults to 10000ms.
Used 1GB for testing.
Types of changes
Checklist
Further comments