Provide clarity on the Create Bucket screen #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
TimCsaky
reviewed
Mar 21, 2023
jujaga
reviewed
Mar 21, 2023
bcgv123
force-pushed
the
feat/3103-provide-clarity-bucket-config
branch
from
3bb079e to
287e19b
Compare
jujaga
approved these changes
Mar 22, 2023
kamorel
approved these changes
Mar 22, 2023
added 6 commits
March 22, 2023 14:20
…lpText. Removing Key from validation schema - is not mandatory.
…onents as we dont want whitespaces at all
bcgv123
force-pushed
the
feat/3103-provide-clarity-bucket-config
branch
from
dacb6bb to
b488812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified configure bucket form to support new labels/placeholders/helptext/mandatory described in https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3103. Changed custom common 'InputText' and 'Password' vue components to support helpText rendering. Removed 'Key' from validation schema, it's not mandatory anymore.
Description
Types of changes
Checklist
Further comments