Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route entry permission checking #48

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Route entry permission checking #48

merged 3 commits into from
Mar 14, 2023

Conversation

kamorel
Copy link
Contributor

@kamorel kamorel commented Mar 13, 2023 •
edited
Loading

Description

  • Adds a 403 Forbidden page
  • Does a permissions check on object list and file details route entry, moves to a Forbidden page if necessary.
  • Resolves a bug with the BCBox share link
  • Share button now requires READ permission

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@kamorel kamorel force-pushed the feature/perm-check branch from efec427 to aa557af Compare March 13, 2023 19:37
@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 5.38% ( 42 / 781 )
Methods: 0% ( 0 / 181 )
Lines: 8.3% ( 40 / 482 )
Branches: 1.69% ( 2 / 118 )

@kamorel kamorel force-pushed the feature/perm-check branch 2 times, most recently from 37e1809 to cabb802 Compare March 14, 2023 18:07
@kamorel kamorel force-pushed the feature/perm-check branch from cabb802 to eda91cb Compare March 14, 2023 18:15
@jujaga jujaga merged commit ca67644 into master Mar 14, 2023
@jujaga jujaga deleted the feature/perm-check branch March 14, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jujaga jujaga jujaga approved these changes

@TimCsaky TimCsaky TimCsaky approved these changes

@bcgv123 bcgv123 Awaiting requested review from bcgv123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamorel @jujaga @TimCsaky