Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk results modal: change "save results" icon to match BCBox style #216

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

norrisng-bc
Copy link
Contributor

Description

This tweaks the styling of the "save results" button icon for the bulk results modal, so that it matches the style throughout the rest of BCBox (i.e. blue icon with no background). Previously, it was a white icon on a blue button.

This also removes the unneeded argument in exportCSV(), as mentioned in #215 (comment).

https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3679

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

In the interest of time, #215 was pushed to production without these fixes. The current PR is a minor continuation and includes them.

Copy link

codeclimate bot commented Jun 18, 2024

Code Climate has analyzed commit 4c3d20a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 23.8% (0.0% change).

View more on Code Climate.

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

github-actions bot commented Jun 18, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 18.36% ( 753 / 4101 )
Methods: 17.9% ( 138 / 771 )
Lines: 22.69% ( 532 / 2345 )
Branches: 8.43% ( 83 / 985 )

@norrisng-bc norrisng-bc force-pushed the bugfix/save-bulk-results-button-style branch from 65d3241 to 4c3d20a Compare June 18, 2024 23:33
@jatindersingh93
Copy link
Contributor

I would suggest to add background color to the hover over to keep it consistent with close button
Here is something already exists

.p-dialog .p-dialog-header .p-dialog-header-icon:enabled:hover { color: #495057; border-color: transparent; background: #e9ecef; }

Screenshot 2024-06-18 at 4 43 26 PM

@norrisng-bc
Copy link
Contributor Author

I would suggest to add background color to the hover over to keep it consistent with close button Here is something already exists

.p-dialog .p-dialog-header .p-dialog-header-icon:enabled:hover { color: #495057; border-color: transparent; background: #e9ecef; }

I based my button off the existing action buttons (i.e. the ones on the right of the object table) - I don't think this kind of shading is present there. I'd probably defer to Tyler on that, to be honest.

@TimCsaky TimCsaky merged commit 4eb0788 into master Jun 19, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants