Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Navigation for Child configuration model #213

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Tab Navigation for Child configuration model #213

merged 1 commit into from
Jun 17, 2024

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented Jun 14, 2024

Fix tab order, start from entire popup, heading and end with close button
Focus should go back to the config button when hit closed
Focus should stay in the open dialog box

SC3685

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codeclimate bot commented Jun 14, 2024

Code Climate has analyzed commit a5ac28d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 25.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 23.8% (0.0% change).

View more on Code Climate.

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

github-actions bot commented Jun 14, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 18.38% ( 751 / 4085 )
Methods: 17.95% ( 138 / 769 )
Lines: 22.66% ( 530 / 2339 )
Branches: 8.5% ( 83 / 977 )

@jatindersingh93 jatindersingh93 force-pushed the SC3685 branch 2 times, most recently from 93b0dfb to 3c3935f Compare June 14, 2024 20:17
@jatindersingh93 jatindersingh93 marked this pull request as ready for review June 14, 2024 20:24
@TimCsaky TimCsaky merged commit c74264c into master Jun 17, 2024
18 of 19 checks passed
@TimCsaky TimCsaky deleted the SC3685 branch June 18, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants