Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab navigation and aria labels for permissions model #211

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented Jun 7, 2024

  • Make folder and file permissions keyboard accessible
  • Make permission table keyboard and screen able accessible
  • Focus back to the button element when model is closed
  • Add aria tags for screen reader
  • Make content in model screen reader friendly
  • Keep focus in the model so outside DOM elements are not available

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Jun 7, 2024

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

github-actions bot commented Jun 7, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 19.22% ( 721 / 3751 )
Methods: 18.77% ( 137 / 730 )
Lines: 23.12% ( 501 / 2167 )
Branches: 9.72% ( 83 / 854 )

Copy link

codeclimate bot commented Jun 7, 2024

Code Climate has analyzed commit 04d6c23 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 14.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.4% (0.0% change).

View more on Code Climate.

@jatindersingh93 jatindersingh93 marked this pull request as ready for review June 12, 2024 00:10
@jatindersingh93 jatindersingh93 force-pushed the SC3687 branch 3 times, most recently from 0b74360 to 5138a0f Compare June 12, 2024 16:34
Copy link
Contributor

@TimCsaky TimCsaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. good to have this pattern to re-use

@TimCsaky TimCsaky merged commit 006527d into master Jun 12, 2024
18 of 19 checks passed
@TimCsaky TimCsaky deleted the SC3687 branch June 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants