Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make READ perm optional for folder invites #210

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Make READ perm optional for folder invites #210

merged 1 commit into from
Jun 5, 2024

Conversation

TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented Jun 5, 2024

add help text for invite form
additional bug-fix: require READ perm for bucket sync

Description

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3696

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Jun 5, 2024

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

github-actions bot commented Jun 5, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 19.13% ( 715 / 3738 )
Methods: 18.66% ( 136 / 729 )
Lines: 23.07% ( 498 / 2159 )
Branches: 9.53% ( 81 / 850 )

Copy link

codeclimate bot commented Jun 5, 2024

Code Climate has analyzed commit f645d91 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 31.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.3% (0.0% change).

View more on Code Climate.

add help text for invite form
additional bug-fix: require READ perm for bucket sync
@TimCsaky TimCsaky merged commit 348fa6c into master Jun 5, 2024
18 of 19 checks passed
@TimCsaky TimCsaky deleted the bucket-read branch June 5, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants