Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard navigation to Share Model #206

Merged
merged 1 commit into from
May 30, 2024
Merged

Add keyboard navigation to Share Model #206

merged 1 commit into from
May 30, 2024

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented May 28, 2024 •
edited
Loading

  • Can tab all elements
  • focus does not goes out of the dialog
  • Focus goes back to the button when exit model

SC3658

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions GitHub Actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@github-actions GitHub Actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 19.16% ( 705 / 3679 )
Methods: 18.58% ( 133 / 716 )
Lines: 22.95% ( 491 / 2139 )
Branches: 9.83% ( 81 / 824 )

@codeclimate CodeClimate
Copy link

codeclimate bot commented May 28, 2024

Code Climate has analyzed commit 35b6430 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 66.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.2% (0.0% change).

View more on Code Climate.

@jatindersingh93 jatindersingh93 marked this pull request as ready for review May 28, 2024 22:29
@TimCsaky TimCsaky merged commit 44a4652 into master May 30, 2024
18 of 19 checks passed
@TimCsaky TimCsaky deleted the sc-3658 branch May 30, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimCsaky TimCsaky TimCsaky approved these changes

@norrisng-bc norrisng-bc Awaiting requested review from norrisng-bc norrisng-bc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jatindersingh93 @TimCsaky