Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: only fetch permissions for objects in table #204

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

TimCsaky
Copy link
Contributor

Description

when loading object table, after fetching objects we fetch object permissions.
If folder is empty and there are no objects, the call to fetch object permissions searches perms for all objects in entire COMS db.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 19.16% ( 709 / 3701 )
Methods: 18.57% ( 135 / 727 )
Lines: 22.94% ( 493 / 2149 )
Branches: 9.82% ( 81 / 825 )

Copy link

codeclimate bot commented May 27, 2024

Code Climate has analyzed commit 5826903 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.2% (0.0% change).

View more on Code Climate.

@TimCsaky TimCsaky merged commit ffdcdb1 into master May 27, 2024
18 of 19 checks passed
@TimCsaky TimCsaky deleted the bug/loading branch May 30, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants