Separate Share and Invite components #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
| </script> | ||
|
|
||
| <template> | ||
| <h3 class="mt-1 mb-2">{{ (props.label) }} Invite</h3> |
There was a problem hiding this comment.
Remove 'Invite' text as props.label already have full text causing invite text appear multiple times.
|
I am unable to test invite send function may be due to config settings. May be something we can touchbase next week. |
Coverage Report (Frontend)
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit fbdd068 and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 15.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 24.2% (0.0% change). View more on Code Climate. |
TimCsaky
force-pushed
the
move-share
branch
3 times, most recently
from
410e268 to
378879d
Compare
|
Release e537173 deployed at https://bcbox-dev-pr-203.apps.silver.devops.gov.bc.ca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Checklist
Further comments