Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invite email form validation #202

Closed
wants to merge 1 commit into from
Closed

Add invite email form validation #202

wants to merge 1 commit into from

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented May 22, 2024

  • Add Email validation to the invite link
  • Validate using Regex
  • Notify if email syntax is not correct
  • currently not using required, we may deal in a separate ticket as it may require conditional schema

SC3599

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@jatindersingh93 jatindersingh93 force-pushed the SC3599 branch 7 times, most recently from 830dd7e to 7464413 Compare May 22, 2024 22:34
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 19.16% ( 709 / 3701 )
Methods: 18.57% ( 135 / 727 )
Lines: 22.94% ( 493 / 2149 )
Branches: 9.82% ( 81 / 825 )

Copy link

codeclimate bot commented May 22, 2024

Code Climate has analyzed commit 15ac109 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 45.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.2% (0.0% change).

View more on Code Climate.

@jatindersingh93 jatindersingh93 marked this pull request as ready for review May 22, 2024 22:54
Copy link
Contributor

@norrisng-bc norrisng-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const emails = isRestricted.value && formData.value.email ? [formData.value.email] : [];

Looks like this line isn't correctly grabbing the email field in the form - formData.value.email returns undefined, so emails never gets populated with the entered email address and the call to the BCBox /email endpoint is never made.

The invite link gets created just fine though.

@TimCsaky TimCsaky deleted the SC3599 branch May 30, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants