Display confirmation dialog and toasts on toggling file to public #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toasts are also displayed when toggling file to private
Coverage Report (Application)
|
|
Code Climate has analyzed commit f6485a5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 24.6% (0.0% change). View more on Code Climate. |
Coverage Report (Frontend)
|
jatindersingh93
approved these changes
May 16, 2024
| acceptLabel: 'Confirm', | ||
| rejectLabel: 'Cancel', | ||
| accept: () => { | ||
| objectStore |
There was a problem hiding this comment.
Not a show stopper, just for future reference. Consider moving logic into a separate function, which can be called in multiple places.
TimCsaky
approved these changes
May 16, 2024
| @@ -66,6 +66,7 @@ onBeforeMount(() => { | |||
| class="ml-4" | |||
| :bucket-id="object.bucketId" | |||
| :object-id="object.id" | |||
| :object-name="object.name" | |||
| :object-public="object.public" | |||
There was a problem hiding this comment.
i guess we could just pass the whole object in one binding (:object="object") instead of 4 separate ones, and break it down in the child component, and i think we've found some other ways since adopting this pattern early on.. but this is fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting the "set to public" switch to "on" (in both the object table and file permissions modal) now opens an additional modal that asks the user to confirm before doing so:
(this dialog is only displayed when toggling a file from private to public)
A toast is then displayed:
A toast is also displayed when toggling a file from public to private:
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3667
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments
N/A