-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display last sync date for buckets and objects #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle1morel
reviewed
Mar 12, 2024
251887d
to
b2f3b14
Compare
jujaga
reviewed
Mar 12, 2024
wilwong89
reviewed
Mar 12, 2024
b8b82b8
to
dd60d62
Compare
kyle1morel
approved these changes
Mar 12, 2024
dd60d62
to
6bf9d01
Compare
TimCsaky
approved these changes
Mar 13, 2024
COMSObject.lastSyncedDate: object properties, sync modal Bucket.lastSyncRequestedDate: bucket sidebar, sync modal
6bf9d01
to
25d5d5e
Compare
jujaga
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The last sync date for objects and buckets is now displayed in the following places:
In the backend DB, objects have a
lastSyncedDate
while buckets havelastSyncRequestedDate
- both are displayed as "last sync date" in BCBox for brevity.In some cases, the last sync date is not available (i.e. it has a value of
null
in the backend DB because it hasn't been synced after sync date tracking was implemented):"N/A""(none)" is displayed insteada blank space is displayed next to "last sync date""(none)" is displayed insteadEdit (2024-03-12, 17:26 PDT): show
(none)
instead ofN/A
or<blank space>
Jira tickets:
Screenshots
"File details" page:
![Screenshot 2024-03-11 at 3 53 28 PM](https://private-user-images.githubusercontent.com/103449568/311894893-b97bb3af-d612-44f6-ae89-b6641b754b60.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODY1MjIsIm5iZiI6MTczOTI4NjIyMiwicGF0aCI6Ii8xMDM0NDk1NjgvMzExODk0ODkzLWI5N2JiM2FmLWQ2MTItNDRmNi1hZTg5LWI2NjQxYjc1NGI2MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNTAzNDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mNDE2NjdmN2E2ZWM5ODczM2I1MjBlZDk1YmVhMDBkNGYxNWExMjI2NGJmNzQ4ODJkYzQ0YzBmMjlmMDhiNjY3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.aL40klkbb-PwDNST6bqkseFB19iT7NRgcKIkZeIQq8Y)
"Bucket details" sidebar:
![Screenshot 2024-03-11 at 3 46 40 PM](https://private-user-images.githubusercontent.com/103449568/311895015-b600b7ee-f183-4c3a-9847-26884bbfdd30.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODY1MjIsIm5iZiI6MTczOTI4NjIyMiwicGF0aCI6Ii8xMDM0NDk1NjgvMzExODk1MDE1LWI2MDBiN2VlLWYxODMtNGMzYS05ODQ3LTI2ODg0YmJmZGQzMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNTAzNDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZjM1NmY0ZDljOTc0OGY2MTZmZWE5MjY4ZmEzNzc4Y2IxNzMzY2Y4ZGRiYzQ3NDRlYmFhMGQxZWU4ZTc3MGM3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.0W0TXE6IkNsBGoT1e1Mq00-7eqgHMR0yoZo6jYx-mhE)
"Bucket details" sidebar (no last sync date available):
![Screenshot 2024-03-11 at 4 49 18 PM](https://private-user-images.githubusercontent.com/103449568/311896450-b7daebf9-b7aa-4fb4-bc42-02507aeec47b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODY1MjIsIm5iZiI6MTczOTI4NjIyMiwicGF0aCI6Ii8xMDM0NDk1NjgvMzExODk2NDUwLWI3ZGFlYmY5LWI3YWEtNGZiNC1iYzQyLTAyNTA3YWVlYzQ3Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNTAzNDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iM2M2NjhjMGNkYmJlZWZlMjMyMWVmNjcwMWIxNjg5ZjlkYjEzOWNmMzUyZDk1ZmM2MzQ0MDgzYzMyNjRjMjZmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.RmtwiYlWtWaw8QNDi8RUVW81tpuu0V6u8ZeaAO4rWK0)
Sync modal:
![Screenshot 2024-03-11 at 3 50 15 PM](https://private-user-images.githubusercontent.com/103449568/311895050-3e0eb241-204e-4f6f-9c17-d3232e916692.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODY1MjIsIm5iZiI6MTczOTI4NjIyMiwicGF0aCI6Ii8xMDM0NDk1NjgvMzExODk1MDUwLTNlMGViMjQxLTIwNGUtNGY2Zi05YzE3LWQzMjMyZTkxNjY5Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNTAzNDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05NWFkZWMxZmI3MzI0YTUxMWVjY2YyMGRkNzE5MjZjMjBlMDgyZTRhMzkzYWI2MTJlNzZjZTk5ZmMxOTdhMzVkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.xJQj4jRuCzWpagbMQjXw1wbZhaYOpH9wpwLPSGfXnBM)
Sync modal (no last sync date available):
![Screenshot 2024-03-11 at 3 40 17 PM](https://private-user-images.githubusercontent.com/103449568/311895201-7167e299-e3c8-483e-8c98-d9cb8138b1f5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODY1MjIsIm5iZiI6MTczOTI4NjIyMiwicGF0aCI6Ii8xMDM0NDk1NjgvMzExODk1MjAxLTcxNjdlMjk5LWUzYzgtNDgzZS04Yzk4LWQ5Y2I4MTM4YjFmNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNTAzNDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hMTRhMmVlNjlkNzQzMmEzYjM5NDI3MTA1MGRjODZjNGI3YWFhYmFhMjdlYTIzMjAwOWZlYWJjN2ZlYjgwNzhjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Np89aYFyM2pGLkhFlaFXG8xCQKufYmKqKhSkUkTs9S4)
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments
N/A