Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display last sync date for buckets and objects #181

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

norrisng-bc
Copy link
Contributor

@norrisng-bc norrisng-bc commented Mar 11, 2024

Description

The last sync date for objects and buckets is now displayed in the following places:

  • Objects
    • "File details" page (but not in the sidebar)
    • Sync modal
  • Buckets
    • "My buckets" page, in the sidebar
    • Sync modal

In the backend DB, objects have a lastSyncedDate while buckets have lastSyncRequestedDate - both are displayed as "last sync date" in BCBox for brevity.

In some cases, the last sync date is not available (i.e. it has a value of null in the backend DB because it hasn't been synced after sync date tracking was implemented):

  • Sync modal: "N/A" "(none)" is displayed instead
  • "File details" page: last sync date is omitted entirely (including the "last sync date" text)
  • "My buckets" sidebar: a blank space is displayed next to "last sync date" "(none)" is displayed instead

Edit (2024-03-12, 17:26 PDT): show (none) instead of N/A or <blank space>

Jira tickets:

Screenshots

"File details" page:
Screenshot 2024-03-11 at 3 53 28 PM

"Bucket details" sidebar:
Screenshot 2024-03-11 at 3 46 40 PM

"Bucket details" sidebar (no last sync date available):
Screenshot 2024-03-11 at 4 49 18 PM

Sync modal:
Screenshot 2024-03-11 at 3 50 15 PM

Sync modal (no last sync date available):
Screenshot 2024-03-11 at 3 40 17 PM

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

N/A

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

github-actions bot commented Mar 11, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 18.3% ( 627 / 3427 )
Methods: 17.77% ( 123 / 692 )
Lines: 21.91% ( 436 / 1990 )
Branches: 9.13% ( 68 / 745 )

@norrisng-bc norrisng-bc force-pushed the bucket-object-lastSyncDate branch 2 times, most recently from 251887d to b2f3b14 Compare March 12, 2024 16:29
@norrisng-bc norrisng-bc force-pushed the bucket-object-lastSyncDate branch 2 times, most recently from b8b82b8 to dd60d62 Compare March 12, 2024 19:13
@norrisng-bc norrisng-bc force-pushed the bucket-object-lastSyncDate branch from dd60d62 to 6bf9d01 Compare March 12, 2024 23:41
COMSObject.lastSyncedDate: object properties, sync modal
Bucket.lastSyncRequestedDate: bucket sidebar, sync modal
@norrisng-bc norrisng-bc force-pushed the bucket-object-lastSyncDate branch from 6bf9d01 to 25d5d5e Compare March 13, 2024 00:26
@kyle1morel kyle1morel merged commit 6507aa7 into master Mar 13, 2024
19 of 20 checks passed
@kyle1morel kyle1morel deleted the bucket-object-lastSyncDate branch March 13, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants