fix:(SC-3376) Handle delete success/fail toasts on a per object basis #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
jujaga
reviewed
Oct 17, 2023
jujaga
reviewed
Oct 19, 2023
TimCsaky
approved these changes
Oct 19, 2023
objectStore.ts now uses Promise.allSettled instead of Promise.all and returns an array of objects for each promise with their status. DeleteObjectButton.vue waits for the array and displays a toast based on each success or fail.
jujaga
approved these changes
Oct 25, 2023
| @@ -70,7 +70,7 @@ describe('Object Store', () => { | |||
|
|
|||
| let createObjectSpy: SpyInstance; | |||
| let deleteObjectSpy: SpyInstance; | |||
| let fetchObjectsSpy: SpyInstance; | |||
| // let fetchObjectsSpy: SpyInstance; | |||
There was a problem hiding this comment.
Not a big concern, just wondering why fetchObjectsSpy are commented and not removed?
jatindersingh93
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
objectStore.ts now uses Promise.allSettled instead of Promise.all and returns an array of objects for each promise with their status.
DeleteObjectButton.vue waits for the array and displays a toast based on each success or fail.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist
Further comments
Deleting a list of 3 files looks as follows.