Make Object / Version dates more accurate #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
TimCsaky
requested review from
jatindersingh93,
norrisng-bc,
kamorel and
jujaga
and removed request for
jujaga
Coverage Report (Frontend)
|
TimCsaky
force-pushed
the
dates
branch
2 times, most recently
from
bb4c806 to
d519504
Compare
jujaga
reviewed
Oct 12, 2023
| @@ -14,6 +14,7 @@ import type { Metadata } from '@/types'; | |||
|
|
|||
| // Props | |||
| type Props = { | |||
| bucketId: string | undefined ; | |||
There was a problem hiding this comment.
I believe this can be changed to optional attribute instead of explicit undefined typing:
bucketId?: string;There was a problem hiding this comment.
i forget why but using bucketId?: string; shows a linting error
norrisng-bc
approved these changes
Oct 12, 2023
TimCsaky
force-pushed
the
dates
branch
2 times, most recently
from
1158a83 to
8225af6
Compare
jujaga
approved these changes
Oct 13, 2023
no longer show version-specific created/updated by/dates for each version.
show incrementing version number await user search when showing created by details show createdAt or updatedAt depending on bucket versioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3347
and a mix of other minor changes:
Types of changes
Checklist
Further comments