Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: stop loading files into browser memory before upload #118

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

wilwong89
Copy link
Contributor

Prevent loading large files into browser memory before upload. In objectService.ts

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Requesting someone upload a large (>5 GB file) and ensure that file is not loaded into browser memory.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Coverage Report (Frontend)

Totals Coverage
Statements: 36.97% ( 447 / 1209 )
Methods: 37.92% ( 102 / 269 )
Lines: 43.69% ( 308 / 705 )
Branches: 15.74% ( 37 / 235 )

@TimCsaky TimCsaky requested a review from norrisng-bc September 6, 2023 23:37
@TimCsaky TimCsaky merged commit 728fc33 into master Sep 7, 2023
@TimCsaky TimCsaky deleted the bug/SC-3335 branch September 7, 2023 17:27
@TimCsaky TimCsaky changed the title SC-3335, bug: stop loading files into browser memory before upload bug: stop loading files into browser memory before upload Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants