apply review suggestions

bcgov · Oct 18, 2023 · 54a0360 · 54a0360
1 parent 321509f
commit 54a0360
Show file tree

Hide file tree

Showing 15 changed files with 28 additions and 28 deletions.
diff --git a/frontend/src/components/bucket/BucketList.vue b/frontend/src/components/bucket/BucketList.vue
@@ -48,8 +48,8 @@ onMounted(async () => {
 <template>
   <div>
     <div>
-      <h2>Select a bucket</h2>
-      <h3>Buckets are containers for storing objects.</h3>
+      <h1>Select a bucket</h1>
+      <h2>Buckets are containers for storing objects.</h2>
       <Message
         v-if="getConfig?.notificationBanner"
         severity="warn"

diff --git a/frontend/src/components/bucket/BucketSidebar.vue b/frontend/src/components/bucket/BucketSidebar.vue
@@ -72,7 +72,7 @@ watch(props, () => {
         icon="fa-solid fa-circle-info"
         style="font-size: 2rem"
       />
-      <h2>Bucket details</h2>
+      <h1>Bucket details</h1>
     </div>
     <div class="col-fixed align-items-center">
       <Button

diff --git a/frontend/src/components/bucket/BucketTable.vue b/frontend/src/components/bucket/BucketTable.vue
@@ -134,7 +134,7 @@ async function deleteBucket(bucketId: string) {
           <Button
             v-if="permissionStore.isBucketActionAllowed(data.bucketId, getUserId, Permissions.MANAGE )"
             class="p-button-lg p-button-text"
-            aria-label="Bucket Permissions"
+            aria-label="Bucket permissions"
             @click="showPermissions(data.bucketId, data.bucketName)"
           >
             <font-awesome-icon icon="fa-solid fa-users" />

diff --git a/frontend/src/components/common/SyncButton.vue b/frontend/src/components/common/SyncButton.vue
@@ -110,7 +110,7 @@ const onClick = () => {
 
   <Button
     class="p-button-lg p-button-text"
-    aria-label="Synchronize File"
+    aria-label="Synchronize file"
     @click="onClick"
   >
     <font-awesome-icon icon="fa-solid fa-sync" />

diff --git a/frontend/src/components/layout/Navbar.vue b/frontend/src/components/layout/Navbar.vue
@@ -25,9 +25,9 @@ const { getIsAuthenticated } = storeToRefs(useAuthStore());
             v-if="getIsAuthenticated"
             class="mr-2"
           >
-            <router-link 
+            <router-link
               :to="{ name: RouteNames.LIST_BUCKETS }"
-              aria-label="My Buckets"
+              aria-label="My buckets"
             >
               My Buckets
             </router-link>
@@ -36,7 +36,7 @@ const { getIsAuthenticated } = storeToRefs(useAuthStore());
             <a
               target="_blank"
               href="https://github.com/bcgov/bcbox/wiki"
-              aria-label="BCBox Wiki"
+              aria-label="BCBox help"
             >Help</a>
           </li>
         </ol>

diff --git a/frontend/src/components/object/DeleteObjectButton.vue b/frontend/src/components/object/DeleteObjectButton.vue
@@ -76,7 +76,7 @@ const confirmDelete = () => {
     v-if="props.mode === ButtonMode.ICON"
     class="p-button-lg p-button-text p-button-danger"
     :disabled="props.disabled"
-    aria-label="Delete Object"
+    aria-label="Delete object"
     @click="confirmDelete()"
   >
     <font-awesome-icon icon="fa-solid fa-trash" />
@@ -85,7 +85,7 @@ const confirmDelete = () => {
     v-else
     class="p-button-outlined p-button-danger"
     :disabled="props.disabled"
-    aria-label="Delete Object"
+    aria-label="Delete object"
     @click="confirmDelete()"
   >
     <font-awesome-icon

diff --git a/frontend/src/components/object/DownloadObjectButton.vue b/frontend/src/components/object/DownloadObjectButton.vue
@@ -57,7 +57,7 @@ const download = () => {
     v-if="props.mode === ButtonMode.ICON"
     class="p-button-lg p-button-text"
     :disabled="props.disabled"
-    aria-label="Download Object"
+    aria-label="Download object"
     @click="download()"
   >
     <font-awesome-icon icon="fa-solid fa-download" />
@@ -67,7 +67,7 @@ const download = () => {
     class="mr-2"
     outlined
     :disabled="props.disabled"
-    aria-label="Download Object"
+    aria-label="Download object"
     @click="download()"
   >
     <font-awesome-icon

diff --git a/frontend/src/components/object/ObjectList.vue b/frontend/src/components/object/ObjectList.vue
@@ -106,7 +106,7 @@ onMounted(async () => {
         v-if="permissionStore.isBucketActionAllowed(props.bucketId as string, getUserId, Permissions.CREATE)"
         class="mr-2"
         :disabled="displayUpload"
-        aria-label="Show Object"
+        aria-label="Show object"
         @click="showUpload"
       >
         <font-awesome-icon

diff --git a/frontend/src/components/object/ObjectSidebar.vue b/frontend/src/components/object/ObjectSidebar.vue
@@ -52,7 +52,7 @@ watch( props, () => {
         icon="fa-solid fa-circle-info"
         style="font-size: 2rem"
       />
-      <h2>File details</h2>
+      <h1>File details</h1>
     </div>
     <div>
       <Button

diff --git a/frontend/src/components/object/ObjectTable.vue b/frontend/src/components/object/ObjectTable.vue
@@ -233,7 +233,7 @@ const filters = ref({
             v-if="permissionStore.isObjectActionAllowed(
               data.id, getUserId, Permissions.MANAGE, props.bucketId as string)"
             class="p-button-lg p-button-text"
-            aria-label="Object Permissions"
+            aria-label="Object permissions"
             @click="showPermissions(data.id)"
           >
             <font-awesome-icon icon="fa-solid fa-users" />
@@ -243,7 +243,7 @@ const filters = ref({
             v-if="data.public || permissionStore.isObjectActionAllowed(
               data.id, getUserId, Permissions.READ, props.bucketId as string)"
             class="p-button-lg p-button-rounded p-button-text"
-            aria-label="Synchronize Bucket"
+            aria-label="Synchronize bucket"
             @click="showInfo(data.id)"
           >
             <font-awesome-icon icon="fa-solid fa-circle-info" />

diff --git a/frontend/src/components/object/share/ShareObjectButton.vue b/frontend/src/components/object/share/ShareObjectButton.vue
@@ -95,7 +95,7 @@ onMounted( () => {
 
   <Button
     class="p-button-lg p-button-text"
-    aria-label="Share Object"
+    aria-label="Share object"
     @click="displayShareDialog = true"
   >
     <font-awesome-icon icon="fa-solid fa-share-alt" />

diff --git a/frontend/src/views/DeveloperView.vue b/frontend/src/views/DeveloperView.vue
@@ -11,10 +11,10 @@ const { getConfig } = storeToRefs(useConfigStore());
 </script>
 
 <template>
-  <h2>Developer</h2>
+  <h1>Developer</h1>
   <div>
     <div class="flex mt-3">
-      <h3>Config</h3>
+      <h2>Config</h2>
       <CopyToClipboard
         :mode="ButtonMode.ICON"
         :to-copy="JSON.stringify(getConfig)"
@@ -23,7 +23,7 @@ const { getConfig } = storeToRefs(useConfigStore());
     {{ getConfig }}
 
     <div class="flex mt-3">
-      <h3>Token</h3>
+      <h2>Token</h2>
       <CopyToClipboard
         :mode="ButtonMode.ICON"
         :to-copy="getAccessToken"
@@ -35,7 +35,7 @@ const { getConfig } = storeToRefs(useConfigStore());
     </div>
 
     <div class="flex mt-3">
-      <h3>Profile</h3>
+      <h2>Profile</h2>
       <CopyToClipboard
         :mode="ButtonMode.ICON"
         :to-copy="JSON.stringify(getProfile)"

diff --git a/frontend/src/views/HomeView.vue b/frontend/src/views/HomeView.vue
@@ -21,9 +21,9 @@ const { getConfig } = storeToRefs(useConfigStore());
 
   <div class="flex flex-column mr-8 ml-8">
     <div class="flex justify-content-center mb-5">
-      <h2 class="font-bold">
+      <h1 class="font-bold">
         Store and share files in BCBox
-      </h2>
+      </h1>
     </div>
     <div class="flex justify-content-center mb-5">
       <p class="text-xl text-center">
@@ -54,7 +54,7 @@ const { getConfig } = storeToRefs(useConfigStore());
         src="@/assets/images/home_1.png"
         class="border-1 drop-shadow"
         width="60%"
-        alt="Screenshot of BCBox's file list interface: 
+        alt="Screenshot of BCBox's file list interface:
             a list of example files and possible actions including Upload, Download and Delete."
       />
     </div>
@@ -90,7 +90,7 @@ const { getConfig } = storeToRefs(useConfigStore());
           <img
             src="@/assets/images/home_2.png"
             class="border-1 drop-shadow"
-            alt="Screenshot of BCBox's upload interface: a drag-and-drop area, 
+            alt="Screenshot of BCBox's upload interface: a drag-and-drop area,
                 possible actions including Choose, Start Upload and Close."
           />
         </div>
@@ -118,7 +118,7 @@ const { getConfig } = storeToRefs(useConfigStore());
           <img
             src="@/assets/images/home_3.png"
             class="border-1 drop-shadow"
-            alt="Screenshot of BCBox's share interface, 
+            alt="Screenshot of BCBox's share interface,
                   demonstrating a share link and QR code."
           />
         </div>

diff --git a/frontend/src/views/oidc/OidcCallbackView.vue b/frontend/src/views/oidc/OidcCallbackView.vue
@@ -20,7 +20,7 @@ onMounted(async () => {
 </script>
 
 <template>
-  <h2>Authorizing...</h2>
+  <h1>Authorizing...</h1>
   <Spinner />
 </template>
 

diff --git a/frontend/src/views/oidc/OidcLoginView.vue b/frontend/src/views/oidc/OidcLoginView.vue
@@ -12,7 +12,7 @@ onMounted(() => {
 </script>
 
 <template>
-  <h2>Logging in...</h2>
+  <h1>Logging in...</h1>
   <Spinner />
 </template>