#3258 - Supplier Errors Part 3 #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2024 11:51
guru-aot
changed the title
added 2 commits
December 5, 2024 17:28
...ute-controllers/cas-supplier/_tests_/cas-supplier.aest.controller.getCASSupplier.e2e-spec.ts
Show resolved
Hide resolved
...ute-controllers/cas-supplier/_tests_/cas-supplier.aest.controller.getCASSupplier.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...ute-controllers/cas-supplier/_tests_/cas-supplier.aest.controller.getCASSupplier.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/libs/test-utils/src/factories/cas-supplier.ts
Outdated
Show resolved
Hide resolved
sources/packages/web/src/views/aest/student/CASSupplierInformation.vue
Outdated
Show resolved
Hide resolved
sources/packages/web/src/views/aest/student/CASSupplierInformation.vue
Outdated
Show resolved
Hide resolved
|
SonarCloud test are failing! |
Please take a look at the PR description and if you have some idea, please feel free to share 😉 |
| }, | ||
| { | ||
| title: "Site protected", | ||
| sortable: false, | ||
| key: "siteProtected", | ||
| }, | ||
| { | ||
| title: "Address line 1", |
There was a problem hiding this comment.
The AC states "Address line" only.
andrepestana-aot
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
The table labels vary between starting the second-word uppercase/lowercase.
We should not have it inside the same table. Please check with biz which one should be.
There was a problem hiding this comment.
Confirmed with @CarlyCotton
andrewsignori-aot
approved these changes
Dec 9, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAS errors are shown in the row expander of the CAS Supplier Information table.
E2E test case is created and existing is updated for the changed API.
Failure in the sonarcloud is due to code duplication but I am not able to find the duplication in the code submitted in this PR.