#3035 - Enable Application Saving on Page Change #4001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| !isFirstPage.value && | ||
| !submittingApplication.value | ||
| ) { | ||
| saveDraft(); |
|
There is an outstanding question in the ticket to confirm whether the toast notification should be disabled while automatically saving the draft? |
- Added the code logic to only save draft application when there is a change to the payload - Boolean check to not allow the saving happening again while a draft save is in progress
dheepak-aot
reviewed
Nov 28, 2024
sources/packages/web/src/views/student/financial-aid-application/FullTimeApplication.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Nov 28, 2024
sources/packages/web/src/views/student/financial-aid-application/FullTimeApplication.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Nov 29, 2024
sources/packages/web/src/views/student/financial-aid-application/FullTimeApplication.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Nov 29, 2024
sources/packages/web/src/views/student/financial-aid-application/FullTimeApplication.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 2, 2024
sources/packages/web/src/views/student/financial-aid-application/FullTimeApplication.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 2, 2024
sources/packages/web/src/views/student/financial-aid-application/FullTimeApplication.vue
Show resolved
Hide resolved
dheepak-aot
approved these changes
Dec 2, 2024
dheepak-aot
reviewed
Dec 2, 2024
| @@ -300,7 +300,7 @@ export default defineComponent({ | |||
|
|
|||
| const pageChanged = async ( | |||
| isInFirstPage: boolean, | |||
| currentPage: number, | |||
| _: number, | |||
There was a problem hiding this comment.
I would recommend _currentPage
| const isFirstPage = ref(true); | ||
| const isLastPage = ref(false); | ||
| const isReadOnly = ref(false); | ||
| const notDraft = ref(false); | ||
| const existingApplication = ref({} as ApplicationDataAPIOutDTO); | ||
| const editApplicationModal = ref({} as ModalDialog<boolean>); | ||
| const conditionsAccepted = ref(false); | ||
| // automaticDraftSaveInProgress boolean ensures that multiple api calls for save |
There was a problem hiding this comment.
// automaticDraftSaveInProgress is a boolean...
andrepestana-aot
approved these changes
Dec 2, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following is achieved:
Video illustrating the PR work:
2024-12-02.15-18-21.mp4