Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - restriction view when access limited #3943

Closed
Joshua-Lakusta opened this issue Nov 14, 2024 · 0 comments
Closed

Bug - restriction view when access limited #3943

Joshua-Lakusta opened this issue Nov 14, 2024 · 0 comments
Assignees
@Joshua-Lakusta @lewischen-aot
Labels
Bug Something isn't working Security-related Issues related to security Usability

Comments

@Joshua-Lakusta
Copy link
Collaborator

Joshua-Lakusta commented Nov 14, 2024 •
edited by CarlyCotton
Loading

Describe the Bug
When you view restriction you get trapped and cant close the view when you do not have access to update the restriction.

Expected Behaviour
The 'Close' button is not disabled for all users. Users without restriction edit access should be able to view it, not edit it and then close the modal without refreshing.

Actual Behaviour
The 'Close' button is disabled for users without the restriction edit access. They need to refresh the page in order to get out of the modal.

** Steps To Reproduce**
Steps to reproduce the behaviour:

  1. Go to a student with restrictions as a ministry user with no restriction edit access.
  2. Click on 'View' for any restriction
  3. Un-closable modal reached.

image.png
@Joshua-Lakusta Joshua-Lakusta added Bug Something isn't working Security-related Issues related to security Usability labels Nov 14, 2024
@Joshua-Lakusta Joshua-Lakusta self-assigned this Nov 14, 2024
@Joshua-Lakusta Joshua-Lakusta added Business Items under Business Consideration Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Nov 14, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Nov 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 22, 2024
@lewischen-aot
#3943 - Bug - restriction view when access limited (#3982)
d7ecfd0 
- Removed the check-role-permission decorator to allow ministry users
without designated roles to close the modal as per AC
- The 'Close' button is not disabled for all users. Users without
restriction edit access should be able to view it, not edit it and then
close the modal without refreshing.

Screenshot

![image](https://github.com/user-attachments/assets/455e12e4-8c1d-45a6-82c3-7308a3091275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joshua-Lakusta Joshua-Lakusta

@lewischen-aot lewischen-aot

Labels
Bug Something isn't working Security-related Issues related to security Usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ninosamson @andrewsignori-aot @Joshua-Lakusta @lewischen-aot