Add color for menu highlighting on hover. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better than what we have presently. Much appreciated! |
|
Can we merge this? |
|
@bceskavich should we merge this pull request? |
|
Come on, please merge. We love your theme but the menu issue is maddening. |
|
Hi everyone! @sargalias @felipe1982 @markey apologies for the radio silence on my end. I'll merge this now and get it out into a release later today. |
|
Fantastic, thanks @bceskavich 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Billy,
dracula-at-night is my favorite VSCode theme and the one I use everywhere.
However one thing I find difficult with it is that it doesn't have a hover color for menus, so it's difficult to see what the selection will be. I added a hover color for that. This includes the top menu and context menus from right-clicks. The color I used is the same as the hover color on the top bar menu.
Any comments are welcome and if you don't like the change please let me know.
Before the change: Here I am hovering over the "new terminal" option (the mouse isn't visible on screen captures).
After the change:
