Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.5.0 Feature Work #3

Merged
merged 1 commit into from
Dec 15, 2018
Merged

v2.5.0 Feature Work #3

merged 1 commit into from
Dec 15, 2018

Conversation

bceskavich
Copy link
Owner

JSX Updates

Rethink the way we colorize JSX tags

  • Tag brackes (i.e. < and />) are all colored pink, like many other punctuation elements
  • Component tags are not colored (i.e. are left white), whereas regular DOM tags are colored pink.

I feel this approach makes JSX easier to read, while also maintaining color differentiation b/t Component JSX and DOM Node JSX.

TypeScript Updates

Refactor TypeScript typings coloring to be more consistent

Throughout JS/TS, we adhere to a pattern where data structure definitions (i.e. classes, functions) are colored green, whereas uses of those same data structures (i.e. function invocation, class extension) are colored cyan.

We break this convention with TypeScript typings. Definitions are often colored cyan, whereas uses are colored green.

Here, we fix this inconsistency. TypeScript typing definitions (i.e. interfaces, enums, type aliases) are always colored green. Uses are always colored cyan.

CSS Updates

Update some CSS syntax coloring rules

  • Property value constants are colored cyan. Language constants used elsewhere (like in media queries) are still colored purple.
  • Media query keywords are now colored green

**JSX Updates**

Rethink the way we colorize JSX tags

- Tag brackes (i.e. `<` and `/>`) are all colored pink, like many
  other punctuation elements
- Component tags are not colored (i.e. are left white), whereas
  regular DOM tags are colored pink.

I feel this approach makes JSX easier to read, while also maintaining
color differentiation b/t Component JSX and DOM Node JSX.

**TypeScript Updates**

Refactor TypeScript typings coloring to be more consistent

Throughout JS/TS, we adhere to a pattern where data structure
definitions (i.e. classes, functions) are colored green, whereas uses
of those same data structures (i.e. function invocation, class extension)
are colored cyan.

We break this convention with TypeScript typings. Definitions are often
colored cyan, whereas uses are colored green.

Here, we fix this inconsistency. TypeScript typing definitions (i.e.
interfaces, enums, type aliases) are always colored green. Uses are
always colored cyan.

**CSS Updates**

Update some CSS syntax coloring rules

- Property value constants are colored cyan. Language constants used
  elsewhere (like in media queries) are still colored purple.
- Media query keywords are now colored green
@bceskavich bceskavich merged commit 4a3574e into master Dec 15, 2018
@bceskavich bceskavich deleted the v2.5.0 branch December 15, 2018 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant