Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSX Updates
Rethink the way we colorize JSX tags
<
and/>
) are all colored pink, like many other punctuation elementsI feel this approach makes JSX easier to read, while also maintaining color differentiation b/t Component JSX and DOM Node JSX.
TypeScript Updates
Refactor TypeScript typings coloring to be more consistent
Throughout JS/TS, we adhere to a pattern where data structure definitions (i.e. classes, functions) are colored green, whereas uses of those same data structures (i.e. function invocation, class extension) are colored cyan.
We break this convention with TypeScript typings. Definitions are often colored cyan, whereas uses are colored green.
Here, we fix this inconsistency. TypeScript typing definitions (i.e. interfaces, enums, type aliases) are always colored green. Uses are always colored cyan.
CSS Updates
Update some CSS syntax coloring rules