fix(core): calculate distance to trigger drag-click (#1624)

* fix(core): calculate distance to trigger drag-click Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> * chore(changeset): add Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> --------- Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
bcakmakoglu · Sep 16, 2024 · 6692072 · 6692072
1 parent 1fa90ac
commit 6692072
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/.changeset/poor-lions-rush.md b/.changeset/poor-lions-rush.md
@@ -0,0 +1,5 @@
+---
+"@vue-flow/core": patch
+---
+
+Use calculated drag distance to trigger drag-click.
diff --git a/packages/core/src/composables/useDrag.ts b/packages/core/src/composables/useDrag.ts
@@ -229,8 +229,19 @@ export function useDrag(params: UseDragParams) {
   }
 
   const eventEnd = (event: UseDragEvent) => {
-    if (!dragging.value && !multiSelectionActive.value) {
-      onClick?.(event.sourceEvent)
+    if (!dragStarted && !dragging.value && !multiSelectionActive.value) {
+      const pointerPos = getPointerPosition(event)
+
+      const x = pointerPos.xSnapped - (lastPos.x ?? 0)
+      const y = pointerPos.ySnapped - (lastPos.y ?? 0)
+      const distance = Math.sqrt(x * x + y * y)
+
+      // dispatch a click event if the node was attempted to be dragged but the threshold was not exceeded
+      if (distance !== 0 && distance <= nodeDragThreshold.value) {
+        onClick?.(event.sourceEvent)
+      }
+
+      return
     }
 
     dragging.value = false