fix: Transformations not applied on state change

* Check if transform fix is enabled before applying position
bcakmakoglu · Aug 17, 2021 · d9d664a · d9d664a · vercel · Aug 17, 2021
1 parent ed95a0a
commit d9d664a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/hooks/useDraggable.ts b/src/hooks/useDraggable.ts
@@ -210,7 +210,7 @@ const useDraggable = (target: MaybeRef<any>, options: Partial<DraggableOptions>)
   });
 
   const transform = () => {
-    if (!get(node) || get(state).update === false || !get(state).dragging) return;
+    if (!get(node) || get(state).update === false) return;
     if (get(state).enableTransformFix) removeTransformFix();
 
     const offset = get(state).positionOffset;
@@ -263,7 +263,11 @@ const useDraggable = (target: MaybeRef<any>, options: Partial<DraggableOptions>)
       get(state).y = pos.y;
       get(state).prevPropsPosition = { ...pos };
     }
-    transform();
+    if (get(state).enableTransformFix) {
+      applyTransformFix();
+    } else {
+      transform();
+    }
   };
 
   tryOnUnmounted(() => {

diff --git a/src/utils/types.ts b/src/utils/types.ts
@@ -41,8 +41,6 @@ export interface DraggableOptions extends DraggableCoreOptions {
   defaultPosition: ControlPosition;
   positionOffset?: PositionOffsetControlPosition;
   position?: ControlPosition;
-  x: number;
-  y: number;
 }
 
 export interface DraggableCoreOptions {
@@ -63,7 +61,8 @@ export interface DraggableCoreOptions {
 
 export type DraggableCoreState = State & DraggableCoreOptions;
 
-export type DraggableState = State & DraggableOptions & { prevPropsPosition: { x: number; y: number }; isElementSVG: boolean };
+export type DraggableState = State &
+  DraggableOptions & { x: number; y: number; prevPropsPosition: { x: number; y: number }; isElementSVG: boolean };
 
 interface State {
   dragging: boolean;