Fix QuizTextHandler.makeCorrection() when the correct answer is 0 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeCorrection() should first check whether the user's answer is exactly the same as the correct answer. This fixes the issue that the user's answer would always be marked incorrect if the correct answer was 0, because the division-by-0 in the relative error calculation would produce NaN. For example: http://bcaffo.github.io/courses/06_StatisticalInference/homework/hw4.html#6 Enter '0' for the answer to #2 and click "Submit". The red 'X' icon would appear next to the text box. Next click "Show Answer" and "OK" on the pop-up. The correct answer is 0 and the green checkmark icon is now shown next to the text box for #2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeCorrection() should first check whether the user's answer is exactly
the same as the correct answer. This fixes the issue that the user's
answer would always be marked incorrect if the correct answer was 0,
because the division-by-0 in the relative error calculation would produce
NaN.
For example:
http://bcaffo.github.io/courses/06_StatisticalInference/homework/hw4.html#6
Enter '0' for the answer to #2 and click "Submit". The red 'X' icon would
appear next to the text box. Next click "Show Answer" and "OK" on the
pop-up. The correct answer is 0 and the green checkmark icon is now shown
next to the text box for #2.